Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39915: Use new datastore roots API and add ruff configuration #24

Merged
merged 11 commits into from
Jul 11, 2023
Merged

DM-39915: Use new datastore roots API and add ruff configuration #24

merged 11 commits into from
Jul 11, 2023

Conversation

timj
Copy link
Member

@timj timj commented Jul 7, 2023

Relies on lsst/daf_butler#862

Checklist

  • added documentation for a new migration script

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2023 •
edited
Loading

Codecov Report

Merging #24 (f4dd2dc) into main (7c1fc12) will decrease coverage by 0.50%.
The diff coverage is 63.63%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   56.46%   55.96%   -0.50%     
==========================================
  Files          32       32              
  Lines        1114     1106       -8     
  Branches      254      254              
==========================================
- Hits          629      619      -10     
- Misses        451      453       +2     
  Partials       34       34
Impacted Files Coverage Δ
...ython/lsst/daf/butler_migrate/butler_attributes.py 61.22% <ø> (ø)
...lsst/daf/butler_migrate/script/migrate_add_tree.py 26.66% <ø> (ø)
...lsst/daf/butler_migrate/script/migrate_revision.py 18.51% <0.00%> (-1.49%) ⬇️
...on/lsst/daf/butler_migrate/script/migrate_trees.py 14.63% <0.00%> (-2.04%) ⬇️
...f/butler_migrate/script/rewrite_sqlite_registry.py 19.79% <0.00%> (-1.27%) ⬇️
tests/test_database.py 96.96% <ø> (ø)
tests/test_digests.py 92.00% <ø> (ø)
tests/test_migrate.py 95.00% <ø> (ø)
...daf/butler_migrate/script/migrate_set_namespace.py 30.00% <50.00%> (-3.34%) ⬇️
python/lsst/daf/butler_migrate/config.py 72.09% <100.00%> (ø)
... and 7 more

andy-slac
andy-slac approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for cleaning this neglected package!

@timj timj merged commit 69e109c into main Jul 11, 2023
@timj timj deleted the tickets/DM-39915 branch July 11, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-slac andy-slac andy-slac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timj @codecov-commenter @andy-slac